Re: [RFC] Add hash_pbkdf2 function
| From: | Adam Jon Richardson | Date: | Tue, 19 Jun 2012 06:24:36 +0000 |
| Subject: | Re: [RFC] Add hash_pbkdf2 function | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-60885@lists.php.net to get a copy of this message | ||
On Mon, Jun 18, 2012 at 7:14 PM, Anthony Ferrara <ircmaxell@gmail.com> wrote:
> https://wiki.php.net/rfc/hash_pbkdf2
>
> What are your thoughts?
That's very nice, indeed.
One thing I'm wondering about is whether the last parameter could be
changed from:
raw_output = false
To something like:
output = "hex" (also allowing output = "raw", output = "base64")
Just thinking that most of the time I'd prefer storing the hashed
passwords as base64-encoded strings just because it's more compact,
but this isn't a big deal, just a thought.
Really nice work!
Adam