Re: Re: #61421 for 5.3/4
| From: | Pierre Joye | Date: | Wed, 27 Jun 2012 09:23:38 +0000 |
| Subject: | Re: Re: #61421 for 5.3/4 | ||
| References: | 1 2 3 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-60978@lists.php.net to get a copy of this message | ||
On Wed, Jun 27, 2012 at 11:18 AM, Johannes Schlüter
<johannes@schlueters.de> wrote:
> On Tue, 2012-06-26 at 23:44 -0700, Stas Malyshev wrote:
>> Hi!
>>
>> > I would like to merge the patch from #61421 to all active branches (RMs as CC).
>> >
>> > It is not a new function nor does it add new features but new
>> > constants to support more algorithms for the signature verification.
>>
>> Don't see any problem with it.
>
> It's a feature .. but acceptable -)
Not per se, a grey area where only adding constants could be fine.
Anything else or more complicated is not. But why I ask :)
Waiting David's reply and then I will merge it.
Cheers,
--
Pierre
@pierrejoye | http://blog.thepimp.net | http://www.libgd.org