Re: Re: bug 18556 - tolower & locales

From:	Gustavo Lopes	Date:	Wed, 11 Jul 2012 20:36:40 +0000
Subject:	Re: Re: bug 18556 - tolower & locales
References:	1 2 3 4 5 6 7	Groups:	php.internals
Request:	Send a blank email to internals+get-61139@lists.php.net to get a copy of this message

Em Wed, 11 Jul 2012 22:17:42 +0200, Stas Malyshev <smalyshev@sugarcrm.com> escreveu:

And we regularly fix bugs in such functions in stable versions.
If it is not good enough for 5.3, it is not good enough for 5.4.
Sorry, I can't accept this argument. There were numerous things that are in 5.4 but not in 5.3.

I also think this is not appropriate for 5.4, but for different reasons. You're changing the Zend API. You introduce new public functions. This means an extension that uses the new symbols will be compatible with PHP 5.4.6, but not before. When this happens, it's very annoying (like the PHP_FE_END in 5.3, though that only affected source compatibility -- this also affects binary compatibility). You also change the behavior of zend_binary_strncasecmp(). Just like you had to change ext/standard/string.c, other extensions may also have to (not to mention the risk you missed something). -- Gustavo Lopes