Re: [proposal + pull request] Replace logo GUIDs with data URIs

On Sat, Jul 14, 2012 at 11:48 PM, Stas Malyshev <smalyshev@sugarcrm.com> wrote: > Having the functions to get the images sounds like a good idea, some > sites may want to use them to display the logos. However, I don't think > we should use the same function, as then deciding what the function > actually does is complicated. I'd rather prefer doing something like: > > if(function_exists('php_logo_guid')) { > $url = "/index.php?=".php_logo_guid(); > } else if(function_exists('php_logo_url')) { > $url = php_logo_url(); > } > if(!empty($url)) > echo "<img src=\"$url\" alt=\"php logo\">"; > > it's clear what each function gives me then. I don't think that this is really necessary. If you want to use the PHP logo, just embed it into your website using some URL. We don't need to provide data: URLs for that. Besides, adding a new function and removing the old one would require application changes for the people who used the GUIDs. And in that case it doesn't make much of a difference whether they switch to using data: URLs provided by yet another function or whether they just use a normal URL to a PHP logo. So +1 on removing GUIDs, -1 on adding new functions. Nikita