Re: Run-tests.php JUnit format issue

Em Sat, 28 Jul 2012 01:40:33 +0200, Ferenc Kovacs <tyra3l@gmail.com> escreveu:

ps2: I think there would be still one hiccup in the code: afair we didn't handled the case when a CDATA closure happens to be in the test output, that could be handled by http://www.lshift.net/blog/2007/10/25/xml-cdata-and-escaping I guess.

This same solution (temporarily leaving CDATA) can be applied to encoding those special characters. See: http://ideone.com/csB6b If you turned say, \xF8 to &#xF8;, that would mean you be considering \xF8 to be representing U+00F8, which is actually represented with a different byte sequence in UTF-8. Of course, the underlying problem is that many tests are not encoded in UTF-8. I think Anthony's solution is fine. -- Gustavo Lopes