PHP#62227 (Invalid phar stream path causes crash) was not present in 5.4
| From: | Ondřej Surý | Date: | Thu, 23 Aug 2012 11:54:56 +0000 |
| Subject: | PHP#62227 (Invalid phar stream path causes crash) was not present in 5.4 | ||
| Groups: | php.internals | ||
| Request: | Send a blank email to internals+get-62418@lists.php.net to get a copy of this message | ||
Hi,
this is a documentation bug only which I have discovered when
cherry-picking patches in 5.4.5 and 5.4.6.
PHP Bug #62227 was never present in PHP 5.4 due changes in the code commited in:
commit dd5c478be61a0ef94b54837cfa875c964356e14f
Author: Dmitry Stogov <dmitry@php.net>
Date: Tue Apr 20 11:05:54 2010 +0000
Added concept of interned strings. All strings constants known at
compile time are allocated in a single copy and never changed.
And the merge of 15213768 didn't change the affected code.
Also the test case in the bugreport doesn't segfault in 5.4.4.
Should I fill bug report even for such small nit? (I could.)
Simple patch:
diff --git a/NEWS b/NEWS
index de19a20..8049d5b 100644
--- a/NEWS
+++ b/NEWS
@@ -168,9 +168,6 @@ PHP
NEWS
. Fixed bug #62266 (Custom extension segfaults during xmlParseFile with FPM
SAPI). (Gustavo)
-- Phar:
- . Fixed bug #62227 (Invalid phar stream path causes crash). (Felipe)
-
- Readline:
. Fixed bug #62186 (readline fails to compile - void function should not
return a value). (Johannes)
O.
--
Ondřej Surý <ondrej@sury.org>