Re: PR 186: external protocols and locale independent string conversion

Hi all, On 27/10/12 12:49 PM, Lars Strojny wrote:

Hi, thanks for bringing this up again. I digged even deeper into the whole issue of converting floats to strings and my current findings are that we can’t solve that consistently as things are already fubar’ed. The reason for that is, that in order to solve this issue we would need to make everything locale independent except output functions. Problem is: it’s a thin line. printf("%s", 1.2) is locale aware, echo is as well. But then, should sprintf() be locale aware as well? What about the parameter parsing API (e.g. strpos(1.2, ".") will fail with de_DE as a locale). So: let’s ease the pain where possible, fix things that pop up step by step but I don’t see "the grand solution"[tm] for this problem.

OK; I've removed the extra #include from the pull request and otherwise I think it's a suitable fix for this specific issue. If the new _convert_to_cstring is useful for helping reconcile this elsewhere, then great.

Am 27.10.2012 um 16:33 schrieb Stas Malyshev<smalyshev@sugarcrm.com>: [...]

I'd suggest talking directly to PGSQL maintainers... In general, the pull seems to be fine to me, but I'd rather have the people that understand something in PGSQL APIs look at it :)

I agree with this one. For me, the PR looks fine and it would ease some pain.

Forgive my unfamiliarity with the lines of communication, but would this just mean emailing the individuals mentioned in e.g. the top of the pgsql.c file? Thanks, Alec