Re: [RFC] ICU UConverter implementation for ext/intl
| From: | Pierre Joye | Date: | Tue, 30 Oct 2012 06:27:37 +0000 |
| Subject: | Re: [RFC] ICU UConverter implementation for ext/intl | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-63711@lists.php.net to get a copy of this message | ||
hi Sara!
On Tue, Oct 30, 2012 at 2:57 AM, Sara Golemon <pollita@php.net> wrote:
> http://wiki.php.net/rfc/uconverter
>
> Discuss!
Nice job!
Some comments, raw :) :
- the UCNV prefix is not necessary, we are in the UConverter class
already, I would simply use LATIN_1, or ILLEGAL for exampe.
- It is OO, we should or could use exception. Warning are not nice to
deal with and errors are quite common during conversion
- I would add ERROR_ to the error related constants (UNASSIGNED & co), or?
Some questions, is 'latin1' the same than const UCNV_LATIN_1? or is
there any relation between the two?
Cheers,
--
Pierre
@pierrejoye | http://blog.thepimp.net | http://www.libgd.org