Re: execute_data->Ts removing
| From: | jpauli | Date: | Mon, 03 Dec 2012 14:26:48 +0000 |
| Subject: | Re: execute_data->Ts removing | ||
| References: | 1 2 3 4 5 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-64138@lists.php.net to get a copy of this message | ||
On Mon, Dec 3, 2012 at 2:26 PM, Dmitry Stogov <dmitry@zend.com> wrote:
> Hi Yoram,
>
> Yeas, I checked memory reads on a release PHP built (with -O2 optimization
> level).
>
> The idea is very simple. Before the patch each access to TMP was
> implemented as:
>
> execute_data->Ts + offset
>
> GCC with -O2 kept execute_data in register but it needed to read
> execute_data->Ts anyway and then add the offset
>
> Now we just add the offset to execute_data directly.
>
> Also, the patch I published today is not compatible with 64-bit systems.
> I already fixed it, and the fix is minimal.
>
> Thanks. Dmitry.
>
Great work Dmitry, as usual !
Julien