Re: com php-src: Added a test case for DateTimePoint.: ext/date/tests/date_time_point.phpt
| From: | Pierre Joye | Date: | Wed, 19 Dec 2012 18:58:37 +0000 |
| Subject: | Re: com php-src: Added a test case for DateTimePoint.: ext/date/tests/date_time_point.phpt | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-64361@lists.php.net to get a copy of this message | ||
hi Derick,
On Wed, Dec 19, 2012 at 6:53 PM, Derick Rethans <derick@php.net> wrote:
> Commit: 7c74531e884aaa0a0bf6db76adb0e203cdb81c02
> Author: Derick Rethans <github@derickrethans.nl> Mon, 17 Dec 2012 16:35:52
> +0000
> Parents: d4acb579df4c78acaaff3e90698277e62aac2222
> Branches: immutable-date
>
> Link:
> http://git.php.net/?p=php-src.git;a=commitdiff;h=7c74531e884aaa0a0bf6db76adb0e203cdb81c02
>
> Log:
> Added a test case for DateTimePoint.
I think the way you deal with date is not correct. there were many
voices saying that DateTimePoint was not a good name. Given that
ext/date is enabled by default and standard, you should go through a
RFC for such things, keeping in mind that there was no real concensus
on the name.
This comment should apply to anything in core and standard functions.
Cheers,
--
Pierre
@pierrejoye