Re: Complete traits redesign for 5.5
| From: | Rasmus Lerdorf | Date: | Sat, 22 Dec 2012 12:30:43 +0000 |
| Subject: | Re: Complete traits redesign for 5.5 | ||
| References: | 1 2 3 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-64415@lists.php.net to get a copy of this message | ||
On 12/21/2012 09:28 AM, Dmitry Stogov wrote:
> Hi,
>
> This is more or less final proposed patch for 5.4
>
> http://pastebin.com/ceiWWD4N
>
> It fixes implementation mistakes and makes the whole implementation much
> simpler.
> I hope I didn't introduce new bugs :)
> Of course I checked it with PHP test suite, but it would be great to
> test it with real life applications that use traits.
> The patch keeps binary compatibility, and changes only error messages
> and behavior in error situations.
> It must not affect any applications.
>
> I like to commit the patch in 5.4 and above on next week.
>
> I would simplify the trait implementation much more, but the conflict
> resolution rules allows to make so many tricks that all needs to be
> checked :(
> Anyway, I'll think about it a bit more.
>
> Any feedback is welcome.
You keep spelling "abstract" as "abstarct" throughout the patch. But it
looks good to me. I always like it when a patch removes more lines than
it adds.
-Rasmus