Re: RFC: Add a deprecated modifier for functions

Hello, assuming that you are referring to the RFC about annotations (https://wiki.php.net/rfc/annotations) I don't think that annotations are needed in PHP. Declarations that actually have an impact on the language itself (like deprecated) should rather be implemented as function modifiers while annotations with simple information (like <Author("Mr. X")>) can also be stored in the doc comment (as @author Mr. X). However, I see that Reflection methods like getAnnotation() and hasAnnotation() can be useful sometimes. We could implement methods that fetch information from the doc comment for these cases, for example getDocTag($name) and hasDocTag($name).

On Wed, Dec 26, 2012 at 4:22 PM, Yussuf Khalil <dev@pp3345.de> wrote:

Hello, I have created an RFC about adding a deprecated modifier for functions in PHP, see https://wiki.php.net/rfc/**deprecated-modifier<https://wiki.php.net/rfc/deprecated-modifier>. What are your thoughts on this? Thank you, Yussuf Khalil -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Hi! I think the idea of marking functions as deprecated is great and the current way of throwing E_DEPRECATED error by trigger_error can be improved. In the current state. That's being said, I don't think that adding a deprecated keyword is the solution, since now we can write documentation and set a "@deprecated" mark. I think, that the best solution is the attributes concept that was rejected before and should be re-considered after the last releases changes and language improvements. A few built in attributes, such as <Deprecated> can be great. What do you think?