Re: more inline assembler noise
| From: | Ard Biesheuvel | Date: | Mon, 04 Feb 2013 16:59:53 +0000 |
| Subject: | Re: more inline assembler noise | ||
| References: | 1 2 3 4 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-65639@lists.php.net to get a copy of this message | ||
On 02/04/2013 01:50 PM, Dmitry Stogov wrote:
Attachment: [text/x-patch] 0001-Remove-hardcoded-constants-and-struct-offsets-from-a.patch
I can't remember if I did any special benchmarks except for bench.php when I introduced fast math functions. That time, I rearranged the code to allow inlining of the most probable paths and added assembler code to catch overflow (C can't do it in optimal way). As I remember the bench.php showed some visible improvement.OK, in that case I would still recommend using fewer hardcoded numbers and offsets: please refer to the applied patch, it makes things a bit more robust. However, as I don't expect any speedup for ARM in this area, I will not pursue this any further. Are there any other optimizations involving inline assembler that you implemented for PHP? I would like to review them to see if I need to add an ARM version. Cheers, Ard.
Attachment: [text/x-patch] 0001-Remove-hardcoded-constants-and-struct-offsets-from-a.patch