Re: double val to long val conversion issue
| From: | Gustavo Lopes | Date: | Sun, 17 Feb 2013 23:38:24 +0000 |
| Subject: | Re: double val to long val conversion issue | ||
| References: | 1 2 3 4 5 6 7 8 9 10 11 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-65904@lists.php.net to get a copy of this message | ||
On Mon, 11 Feb 2013 08:05:43 +0100, Stas Malyshev <smalyshev@sugarcrm.com> wrote:
If no one objects, I'll merge this into 5.5 and master: https://github.com/cataphract/php-src/compare/dval_to_lval -- Gustavo Lopes= may be fine, but I am concerned about fmod change for 5.4. If we do it, I'm afraid we may change some scenario, so I'd prefer to make it 5.5 only.This was I was afraid. That bug was just the tip of the iceberg. I suggest we do change the the > operator to >= like you proposed,I will do it later today.