Re: B3, pear segfault
| From: | Rob Richards | Date: | Fri, 19 Dec 2003 11:44:10 +0000 |
| Subject: | Re: B3, pear segfault | ||
| References: | 1 2 3 4 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-6595@lists.php.net to get a copy of this message | ||
Did the problem end up being due to zend_execute.c 1.566 patch?
Within the zend_assign_to_object function, the temp variable needs to be
free'd, otherwise it needs to be handled within the extensions themselves.
Not sure about the other functions in that patch as I only ran into issues
with this function so far in some of the extensions.
ex.
$dom=new domDocument();
$dom->preserveWhiteSpace=false; <- leaks
$array = simplexml_load_string('<array><data>sample
data</data></array>');
$array->data = false; <- leaks and is valid syntax as it gets converted to
string
Within dom (pre 1.566 patch) , I had been handling this in my property write
function (removed the other day) via:
if (! PZVAL_IS_REF(value) && value->refcount == 0) {
value->refcount++;
zval_ptr_dtor(&value);
}
Does this need to go back in or is the code from the 1.566 patch going to be
revisited and re-implemented?
Rob