Re: Merge #62852 and #53437 into 5.3 and 5.4

From: Date: Mon, 18 Mar 2013 17:03:42 +0000
Subject: Re: Merge #62852 and #53437 into 5.3 and 5.4
Groups: php.internals 
Request: Send a blank email to internals+get-66690@lists.php.net to get a copy of this message
Hi, commit f8b91d9ac (fix for #62852) looks fine to me. Commit 0ee71 for #53437 is a bit too much for 5.3 in my opinion - what happens if users have custom work-arounds in extended classes with custom __wakeup or __set_State methods? Will there be a change of behavihor? I think there should be an error message instead of a crash in 5.3. Aside from that: I don't think that E_ERROR is a good error level for the caes, either use E_RECOVERABLE or even just E_WARNING. johannes Anatol Belski <ab@php.net> wrote: >Hi, > >#62852 and #53437 introduced fixes for the date extension crashing when >unserializing objects. They was applied to 5.5. If there are no >objections, I would backport those to 5.3 and 5.4. > >Regards > >Anatol > >-- >PHP Internals - PHP Runtime Development Mailing List >To unsubscribe, visit: http://www.php.net/unsub.php >

« previous php.internals (#66690) next »