RE: [PHP-DEV] E_RECOVERABLE_ERROR for "Call to a member function on a non-object"
| From: | Richard Bradley | Date: | Wed, 20 Mar 2013 16:29:28 +0000 |
| Subject: | RE: [PHP-DEV] E_RECOVERABLE_ERROR for "Call to a member function on a non-object" | ||
| References: | 1 2 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-66719@lists.php.net to get a copy of this message | ||
> > On Wed, Mar 20, 2013 at 3:37 PM, Richard Bradley <Richard.Bradley@softwire.com>
> > wrote:
> >
> > I'd like to patch PHP to make "Call to a member function on a non-object"
> > an E_RECOVERABLE_ERROR
> > instead of an E_ERROR.
>
> > 1. Do I need to create an RFC for this change, or could I just create a pull request
> > in GitHub?
> 1, yes
OK, will do
> > 2. Would anyone object to this change? For example on backwards-compatibility
> > grounds?
> 2, yes
Could you be more specific?
I was hoping to head off some of the objections in this email thread, or at least to avoid coding up
a patch if it is certain to be rejected.
Could you elaborate on what the objections might be, and what measures I could put in place to
overcome them?
> > 3. If I put the effort in to create the RFC and a patch, would it be likely to be
> > accepted?
> 3, depends on the patch
Of course. Could you be more specific? Are there any particular issues the patch would need to
address to be accepted? Anyone in particular I need to convince to get this merged in? Or should I
just do my best and trust in the RFC voting system?
> > 4. Has anyone attempted this change before and had it rejected, or given up?
> 4, yes, at least there were a couple of discussions in general about removing/converting some
> of the fatals to recoverable fatals
Thanks: do you have any pointers for where I can find this?
I get no relevant hits on wiki.php.net or on the "internals" list search at marc.info for
search terms like "E_RECOVERABLE_ERROR" or "Call to a member function on a
non-object".
> ps: there were also
> https://bugs.php.net/bug.php?id=54195&edit=2
Thanks; I'll add this to the list of relevant bugs. I'll update all the bugs if / when the
RFC gets resolved.
Best,
Rich
Richard Bradley
Tel : 020 7485 7500 ext 3230 | Fax : 020 7485 7575
softwire
Sunday Times Best Small Companies 2012 - 6th in the UK
Web : www.softwire.com | Addr : 325 Highgate Studios, 53-79 Highgate Road, London NW5 1TL
Softwire Technology Limited. Registered in England no. 3824658. Registered Office : 13 Station Road,
London N3 2SB