Re: PHP 5.5.0beta1 ZTS broken build
| From: | Rasmus Lerdorf | Date: | Mon, 25 Mar 2013 05:23:34 +0000 |
| Subject: | Re: PHP 5.5.0beta1 ZTS broken build | ||
| References: | 1 2 3 4 5 6 7 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-66790@lists.php.net to get a copy of this message | ||
On 03/24/2013 10:18 PM, Laruence wrote:
> On Mon, Mar 25, 2013 at 12:42 PM, Rasmus Lerdorf <rasmus@lerdorf.com> wrote:
>> Right, but if we handle it like we do with TSRMLS_C throughout the code
>> and always set that %parse-param to this new magic macro we make up and
>> have it point to void *compiler_globals for zendparse() under ZTS mode
>> and void otherwise and make sure it is (re)defined correctly in other
>> places? It might mean we need to refactor zenderror() to take a dummy
>> first arg since it seems to prepend the parse-param type there. Messy.
>
> Hmm, seems fine, a patch is attached:
>
> https://bugs.php.net/patch-display.php?bug_id=64503&patch=bison_build.patch&revision=latest
>
> but there must be some unused parameter term_ls while in non-zts build...
>
Damn you are fast. I was just theorizing that it might work and you have
it implemented before I finished thinking about it.
-Rasmus