Re: [RFC] Internal operator overloading and GMP improvements
| From: | Nikita Popov | Date: | Mon, 13 May 2013 16:16:40 +0000 |
| Subject: | Re: [RFC] Internal operator overloading and GMP improvements | ||
| References: | 1 2 3 4 5 6 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-67422@lists.php.net to get a copy of this message | ||
On Mon, May 13, 2013 at 1:09 PM, Dmitry Stogov <dmitry@zend.com> wrote:
> Hi Nikita,
>
> I didn't get why do we need separate zend_std_compare() function.
> May be I just didn't look careful :)
>
Good point, that was not really necessary. I moved the code back into
compare_function.
> It would be great to look into the patch between master and current of
> your branch.
>
You can find a diff between master and my branch on the PR:
https://github.com/php/php-src/pull/342/files
The relevant diff for the compare handler is here:
https://github.com/php/php-src/pull/342/files#L2R1581
Nikita