Re: com php-src: Add optional second arg to unserialize(): ext/standard/basic_functions.c ext/standard/tests/serialize/serialization_error_001.phpt
ext/standard/tests/serialize/unserialize_consumed.phpt ext/standard/var.c
| From: | Stas Malyshev | Date: | Fri, 17 May 2013 17:14:28 +0000 |
| Subject: | Re: com php-src: Add optional second arg to unserialize(): ext/standard/basic_functions.c ext/standard/tests/serialize/serialization_error_001.phpt ext/standard/tests/serialize/unserialize_consumed.phpt ext/standard/var.c |
||
| References: | 1 2 | Groups: | php.cvs php.internals |
| Request: | Send a blank email to internals+get-67445@lists.php.net to get a copy of this message | ||
Hi!
> Imho this should have been briefly discussed on internals beforehand. At
> least to me this seems rather dubious (why is it needed? why are you
> manually parsing a part of the DLL serialization?) and also clashes with
> Stas' proposed changes to unserialize.
I don't remember any discussion and I think it's rather sad that we're
back to "commit first, ask anybody else maybe" paradigm. There
definitely should be notification on the list prior to changing API of
one of the very frequently used functions in the core.
--
Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/
(408)454-6900 ext. 227