Re: ZEND_NS_NAMED_FE is clearly a frequently used macro
| From: | Derick Rethans | Date: | Tue, 21 May 2013 18:28:54 +0000 |
| Subject: | Re: ZEND_NS_NAMED_FE is clearly a frequently used macro | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-67454@lists.php.net to get a copy of this message | ||
On Tue, 21 May 2013, Sara Golemon wrote:
> It's time to play "Spot the double quoting!"
>
> #define ZEND_NS_FENTRY(ns, zend_name, name, arg_info, flags)
> ZEND_RAW_FENTRY(ZEND_NS_NAME(ns, #zend_name), name, arg_info, flags)
>
> #define ZEND_NS_NAMED_FE(ns, zend_name, name, arg_info) ZEND_NS_FENTRY(ns,
> #zend_name, name, arg_info, 0)
>
>
> ZEND_NS_NAMED_FE("foo", bar, ...)
>
> Gets exported to userspace as: foo\"bar" which is obviously fail.
>
> Any objections to my fixing ZEND_NS_NAMED_FE as: s/#zend/zend/ ?
That was my thought last night as well when I noticed it...
so go for it :-)
cheers,
Derick