Re: Re: #53437

From: Date: Fri, 07 Jun 2013 11:11:15 +0000
Subject: Re: Re: #53437
References: 1 2 3 4  Groups: php.internals 
Request: Send a blank email to internals+get-67641@lists.php.net to get a copy of this message
Hi Derick, On Fri, June 7, 2013 12:45, Derick Rethans wrote: > On Thu, 6 Jun 2013, Pierre Joye wrote: > > >> On Jun 6, 2013 6:03 PM, "Derick Rethans" <derick@php.net> wrote: >> >>> >>> On Thu, 6 Jun 2013, Pierre Joye wrote: >>> >>> >>>> The fix for #53437 is around for some time now. It full fills the >>>> requirements described by Derick when we discussed the possible >>>> fixes. >>>> >>>> Unless there are strong objections in the next couple of days, I >>>> will ask Anatol to apply it on Monday. This is the last remaining >>>> crash in 5.3/4 (already applied in 5.5) and needs to be fixed asap. >>> >>> The last time I checked that it was using weird base64 encoding on >>> stuff and I am absolutely against that. Where is the new patch? >> >> It is in 5.5 and no, it does not used that as stated in the previous >> mails. > > That didn't answer my question though. I asked where the new patch was. > That's the one where conversion int <> string for serialization was developed. It came into 5.5 with this patches (the originally proposed patch is still attached to that ticket) http://git.php.net/?p=php-src.git;a=commitdiff;h=0ee71557ffd285552659b6aa37ea236e3bad493f http://git.php.net/?p=php-src.git;a=commitdiff;h=acd160530a3ef41403853fd983bef3082726b690 http://git.php.net/?p=php-src.git;a=commitdiff;h=add5420d89624550b1e6e72f960413ff7d0a69a2 Those are definitely crying to be backported into 5.3 and 5.4 as the corresponding tests are still crashy. Regards Anatol

« previous php.internals (#67641) next »