Re: test bug60322
| From: | Pierre Joye | Date: | Thu, 13 Jun 2013 18:08:55 +0000 |
| Subject: | Re: test bug60322 | ||
| References: | 1 2 3 4 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-67705@lists.php.net to get a copy of this message | ||
On Thu, Jun 13, 2013 at 7:24 PM, Stas Malyshev <smalyshev@sugarcrm.com> wrote:
> Hi!
>
>> Fails on 5 boxes here.
>>
>> What's your settings?
>
> It would be much more useful to know what is *your* settings, since it
> is where the tests are failing. But never mind, I think I know where the
> problem is.
Yes, but I have to wait until the rest of the team wake up to get the
detailed settings and planed to post them here :)
> The loop in the test:
>
> while(ob_get_clean());
>
> is wrong, since it would terminate at first empty buffer. So if you have
> multiple output buffers stacked (not sure how to create it with INI
> alone, maybe some extensions do that?) the buffers will not be cleaned
> properly by the time it gets to the var_dump, and thus the test would
> work wrong. I'll try to simulate this situation and rewrite the test.
Thanks! I will ask to run that test again and see if your commit fixes it.
Cheers,
--
Pierre
@pierrejoye | http://www.libgd.org