Re: Patch for adding elements to ArrayAccess
| From: | Marcus Boerger | Date: | Sat, 03 Jan 2004 14:12:36 +0000 |
| Subject: | Re: Patch for adding elements to ArrayAccess | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-6771@lists.php.net to get a copy of this message | ||
Hello Simeon,
Saturday, January 3, 2004, 2:04:45 PM, you wrote:
> Hello internals,
> Could anyone who can commit to CVS review this patch and commit it if it's OK?
> The patch was made for php5-200401021030 snapshot, the file
> zend_object_handlers.c. It fixes the bug that using $a[] = 'Something' where
> $a is instance of ArrayAccess will invoke offsetSet() with empty offset.
That's avery bad thing because you check all possible values. And meanwhile
we already decided not to support $a[] with ArrayAccess. If you really want
it then i would sugget that the index/offset passed to offsetSet is NULL.
--
Best regards,
Marcus mailto:helly@php.net