Re: I want to work against Bug 44522 - Upload limit 2G
| From: | Yasuo Ohgaki | Date: | Thu, 27 Jun 2013 21:47:23 +0000 |
| Subject: | Re: I want to work against Bug 44522 - Upload limit 2G | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-67985@lists.php.net to get a copy of this message | ||
Hi
Just a comment for the patch.
2013/6/27 Ralf Lang <lang@b1-systems.de>
> Does anybody know of intricate reasons why the existing patch
>
>
>
> https://bugs.php.net/patch-display.php?bug_id=44522&patch=uploads_larger_than_2g_HEAD_v2&revision=latest
>
> could not be included into php 5.5?
>
It uses long instead of uint but it makes large files available only to
64bit platforms.
It should use off_t along with "#define _FILE_OFFSET_BITS 64", but I'm not
sure if this work under windows. There may be other places that data type
should be changed. It should be checked carefully, otherwise memory fault
may occur due to integer overflow.
Regards,
--
Yasuo Ohgaki
yohgaki@ohgaki.net