Re: Re: hex2bin: E_WARNING is too much for odd string?
| From: | Yasuo Ohgaki | Date: | Fri, 28 Jun 2013 01:27:53 +0000 |
| Subject: | Re: Re: hex2bin: E_WARNING is too much for odd string? | ||
| References: | 1 2 3 4 5 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-67988@lists.php.net to get a copy of this message | ||
Hi Tjerk,
2013/6/27 Tjerk Meesters <tjerk.meesters@gmail.com>
> The thread started with the assertion that it raises a warning and the
> commits first remove the warning and then adds it again later, so isn't the
> whole PR a noop? :)
The issue is inconsistent behavior of hex2bin against invalid inputs.
Both removing and adding E_WARNING provide consistency.
Adding E_WARNING is better than removing as a result discussion, IMO.
Regards,
--
Yasuo Ohgaki
yohgaki@ohgaki.netHi