Re: phar bug #65028

hi we don't have a maintainer for phar as far as I know. Ralph volunteered(twice) to take over phar but was pretty much ignored. He is the last person that I know looking into the phar code and fixing stuff so maybe he could review your changes. On Mon, Jul 22, 2013 at 10:09 AM, Stas Malyshev <smalyshev@sugarcrm.com>wrote: > Hi! > > I was looking at bug https://bugs.php.net/bug.php?id=65028 and > looks > like it happens because phar writes manifest after HALT_COMPILER(); ?> > and first 4 bytes of manifest are manifest length (little-endian), but > when it read the header, it checks if there's \r\n after ?>. So if > length has lowest byte 0x0d or 0x0a, bad things happen. > > I've created https://github.com/php/php-src/pull/392 to > fix this > problem, however I'd like somebody with more familiarity with phar > details to take a look if it's the best way to do it. > > P.S.: BTW, who is official phar maintainer now? I'm seeing that last > commit from anybody listed as maintainer is 4 years ago... Is it time to > update ownership? > -- > Stanislav Malyshev, Software Architect > SugarCRM: http://www.sugarcrm.com/ > (408)454-6900 ext. 227 > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > > -- Ferenc Kovács @Tyr43l - http://tyrael.hu