Re: [PATCH] Constification of some PHP API calls
| From: | Julien Pauli | Date: | Mon, 29 Jul 2013 14:35:22 +0000 |
| Subject: | Re: [PATCH] Constification of some PHP API calls | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-68333@lists.php.net to get a copy of this message | ||
On Mon, Jul 29, 2013 at 12:01 PM, Andrey Hristov <php@hristov.com> wrote:
> Hi,
> after experiencing again warnings about conversion from const char * to
> char * when calling some PHP API functions I decided to spend some time and
> constify a few of these. The result is a patch that constifies the Streams
> API, and few functions in Zend and TSRM (to which I have no karma). Most of
> the changes are conversion of "char *" to "const char *" parameters, where
> applicable. In a few places string lengths are changed from int to size_t.
> Few functions return now "const char *" instead of "char *" (the caller did
> not modify/release these before).
>
> The patch is against php-src because it changes API which can be only done
> in a new version.
>
> Opinions?
>
I'm +1.
About strings sizes from int to size_t , you perhaps could sync with
Anthony who worked hard recently on such changes, especially regarding zval
string type.
Julien.Pauli