Re: com php-src: Merge from GitHub: ext/opcache/ZendAccelerator.c ext/opcache/ZendAccelerator.h
| From: | Dmitry Stogov | Date: | Wed, 31 Jul 2013 08:26:48 +0000 |
| Subject: | Re: com php-src: Merge from GitHub: ext/opcache/ZendAccelerator.c ext/opcache/ZendAccelerator.h | ||
| References: | 1 2 3 4 | Groups: | php.cvs php.internals |
| Request: | Send a blank email to internals+get-68342@lists.php.net to get a copy of this message | ||
Something like the following? (it wasn't tested)
#define ACCELERATOR_VERSION_BASE "7.0.3"
#define ACCELERATOR_VERSION_SUFFIX "-dev"
#iif PHP_EXTRA_VERSION
# define ACCELERATOR_VERSION ACCELERATOR_VERSION_BASE
ACCELERATOR_VERSION_SUFFIX
#else
# define ACCELERATOR_VERSION ACCELERATOR_VERSION_BASE " (" PHP_VERSION ")"
#endif
On Wed, Jul 31, 2013 at 12:27 AM, Stas Malyshev <smalyshev@sugarcrm.com>wrote:
> Hi!
>
> > I agree, this "-dev" suffix is annoying in PHP releases.
> > However, I don't see a simple way to avoid it.
>
> Can we reuse PHP_EXTRA_VERSION from php_version.h? This was dev code
> will keep -dev, but releases would have no suffix. RCs would be marked
> as RC but that shouldn't be a big problem I think.
>
> --
> Stanislav Malyshev, Software Architect
> SugarCRM: http://www.sugarcrm.com/
> (408)454-6900 ext. 227
>