Re: [RFC] Escaping RFC for PHP Core - Updates?

On Sat, Sep 7, 2013 at 10:08 AM, Michael John Burgess < michael@mjburgess.co.uk> wrote: > On 07/09/2013 15:41, Levi Morrison wrote: > >> It looks nicer than Escaper::escapeJs(), Escaper::escapeHtml(), etc. >>> >>> Any comments? >>> >> >> >> Please, don't go down this route. You do not want one class to escape all >> kinds of data; delegate each type of escaping to its own class: >> >> JavaScriptEscaper->escape(); >> PhpEscaper->escape(); >> HtmlEscaper->escape(); >> HtmlAttributeEscaper->escape()**; >> >> I should not have to defend this but I am willing to explain in more >> detail >> if someone would like me to. >> >> > > There doesnt need to be any object-oriented version for this problem. It's > a series of pure functions. Wraping them in one or more classes adds > nothing. If you are making a class then do it properly; if you aren't using a class then use sensible functions. Using a poorly designed class as originally proposed is not helping anything and may hurt as well.