Re: adding class entry getter for JsonSerializeable

Yea, but my php binary doesn't export php_json_serializable_ce. Did I missed something? nm /Users/chobie/.phpenv/versions/5.5-zts-debug/bin/php | grep php_json_serializable_ce 0000000100c00460 s _php_json_serializable_ce 2013/9/8 Nikita Popov <nikita.ppv@gmail.com> > On Sat, Sep 7, 2013 at 5:43 PM, chobie <chobieee@gmail.com> wrote: > >> Hi internals, >> >> I realized we could not retrieve php_json_serializable_ce from other >> extension module. JsonSerializeable interface is easy to serialize with >> json_encode. So I want to adding getter function. >> >> The patch can be found here: >> >> >> https://github.com/chobie/php-src/compare/adding-jsonserializeable-ce-getter >> >> I want to have feedback on the idea. >> > > The code has an "extern zend_class_entry *php_json_serializable_ce;" right > above that line. Shouldn't that be enough? > > Nikita > >