Re: Failing builds on Travis

From: Date: Fri, 27 Sep 2013 07:38:56 +0000
Subject: Re: Failing builds on Travis
References: 1 2  Groups: php.internals 
Request: Send a blank email to internals+get-69378@lists.php.net to get a copy of this message
Hi Mike, On Fri, Sep 27, 2013 at 3:27 PM, Michael Wallner <mike@php.net> wrote: > On 27 September 2013 04:37, Tjerk Meesters <tjerk.meesters@gmail.com> > wrote: > > Hi, > > > > The success of builds on Travis seems to hinge on a particular test case: > > > > ext/standard/tests/file/disk_free_space_basic.phpt > > > > It asserts that if a file is written to, the free space after the write > > must always be lower than the previously recorded value. > > > > On a busy system the free space is affected by many factors that can > cause > > this assertion to fail and thus developers get a nasty looking (X) on > their > > pull requests. > > > > I actually committed a fix some time ago and didn't see a build of > PHP-5.5+ failing for that reason? > Ah, I just saw that you've changed the file size to 0xFFFF bytes now. The fact that my topic branch is 2806 commits behind master probably has something to do with that then ;-) Rebasing my branch should fix it. Sorry for the noise! > > Regards, > Mike > -- -- Tjerk

« previous php.internals (#69378) next »