Re: [RFC] Exceptions in the engine
| From: | Stas Malyshev | Date: | Thu, 24 Oct 2013 19:57:35 +0000 |
| Subject: | Re: [RFC] Exceptions in the engine | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-69855@lists.php.net to get a copy of this message | ||
Hi!
Looking at the patch, it converts zend_error_noreturn into
ZEND_IMPOSSIBLE, which is nothing in non-debug mode. This means code
that expected that execution ceases it this point (and jumps to a safe
bail-out point) now just continues in non-debug mode (probably causing
crash or memory corruption) or exits the process on failed assert in
debug mode. I'm not sure it is a good idea to do this. A lot of code
assumes execution does not proceed past E_ERROR, but exceptions do not
work that way.
--
Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/
(408)454-6900 ext. 227