Re: error_log binary unsafe

Hi Joe, On Sun, Oct 27, 2013 at 6:53 PM, Joe Watkins <krakjoe@php.net> wrote: > I don't see that it needs an RFC for the SAPI to have a means of logging > binary safe data. > > The implementations of FPM and Apache2 are things that might require RFC, > but I don't see that the basic CLI and CGI SAPI's do. > > So it might be best to merge as it is, with cli and cgi implemented for > reference, and then if someone wants to do the Apache2 and FPM > implementations they can, along with an RFC for them. > We need agreement patch that break compatibility/behavior, thus RFC is preferred. As long as we keep consistency, we could say it's not our business but it is users task handle it properly. I would vote some where between -1 to 0 to introduce needless inconsistency. Because users need conversion/escape anyway even if we make error logging binary safe. I'm not against making error logging binary safe, but I don't think we need inconsistency. Regards, -- Yasuo Ohgaki yohgaki@ohgaki.net