Re: size_t and 64 bit integer branch

On Mon, Nov 18, 2013 at 10:43 PM, Anatol Belski <ab@php.net> wrote: > Hi, > > the branch with size_t for string length and 64 bit integer replacement > for long datatype was brought so far. This branch is based on the one > started by Anthony Ferrara. > > Compiled with --disable-all --enable-cli this functionality is already > available. Except of a couple of edge cases, the tests pass on both 64 bit > Windows and Linux. The implementation is ready as a solid base for the > further porting. There are several new macros and typedefs to handle 64 > bit compatibility. All those are placeholders which can be easily renamed > later, if needed. There is a wiki page indicating the current progress and > containing quick start instructions: > > https://wiki.php.net/rfc/string-size_t/progress > > As the base does exist now, I'd like to call the maintainers and > developers to participate on further porting of the core extensions and > SAPIs. Many of those should be easy to convert. Any reviews and comments > on what is done are of course welcome, too. > > The new era of PHP is coming, do your part! :) > > Hi, I have been playing with openssl a bit and made it work with this configuration: --disable-all --enable-cli --enable-debug --with-openssl The commit is here https://github.com/bukka/php-src/commit/215811e3fdb7b4f2786576851c8687c6249c4725 It's just an initial work but it works fine for all tests. However there are lots of issues that need to be properly tested. I made notes about all possible issues that could be a problem: https://gist.github.com/bukka/7617548 Lots of them are just possible loss of data that won't be really problematic but testing is required anyway IMHO. But some issues could be a problem and they need a proper testing. I currently work on my php-crypto ext that I plan to propose for PECL soon. So I will be doing testing for more versions of OpenSSL anyway. I could prepare some tests for edge cases and do it together though. Let me know what you think about the patch! Thanks Regards Jakub