Re: One fail test in 5.5 branch
| From: | Julien Pauli | Date: | Tue, 26 Nov 2013 17:07:51 +0000 |
| Subject: | Re: One fail test in 5.5 branch | ||
| References: | 1 2 3 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-70411@lists.php.net to get a copy of this message | ||
On Tue, Nov 26, 2013 at 5:05 PM, Julien Pauli <jpauli@php.net> wrote:
> On Tue, Nov 26, 2013 at 4:53 PM, Michael Wallner <mike@php.net> wrote:
>
>> On 26 November 2013 16:49, Julien Pauli <jpauli@php.net> wrote:
>> > Hi,
>> >
>> > I got one fail test in 5.5, while I was tagging 5.5.7RC1
>> >
>> > sapi/cli/tests/php_cli_server_019.phpt
>> >
>> > The diff is :
>> >
>> > 022+ string(12) "PHP/5.5.7RC1"
>> > 022- string(13) "P%s"
>> >
>> >
>> > Seems like %s does not catch the version number or something like that ?
>> > Not blocking to tag RC1 though, but should be checked and fixed.
>>
>> String length is 12 vs 13.
>>
>
> Great catch.
> However, version string has a variable size, depending on the presence of
> extra version (aka : RCx) or not.
> I guess something like string(%d) is better then ?
>
> Julien Pauli
>
I patched it and commited it.
Perhaps my pushes on git have not been done the right way, I'm just a
beginner about that. I asked on IRC. Everything seems all right
Julien Pauli