RE: [PHP-DEV] Re: [PHP-CVS] com php-src: Fixed bug #53879 (DateTime::createFromFormat() fails to parse cookie expiration date): ext/date/php_date.c
ext/date/tests/DateTime_format_basic2.phpt ext/date/tests/DateTime_verify.phpt ext/date/tests/bug52063.phpt

> -----Original Message----- > From: Mike [mailto:mike.php.net@gmail.com] > Sent: 02 December 2013 19:07 > To: Derick Rethans > Cc: php-cvs@lists.php.net; PHP Internals > > On Wed, 2013-11-27 at 21:59 +0000, Derick Rethans wrote: > > Commit: 23ab2575e1be062c2d5e3f80d3ff40cabe14fa2c > > Author: Derick Rethans <github@derickrethans.nl> Wed, > 27 Nov 2013 21:59:46 +0000 > > Parents: 504c60dc4451b8ede8814530dbfec0ef485f0ca6 > > Branches: master > > > > Link: http://git.php.net/?p=php- > src.git;a=commitdiff;h=23ab2575e1be062c2d5e3f80d3ff40cabe14fa2c > > > > Log: > > Fixed bug #53879 (DateTime::createFromFormat() fails to parse > cookie expiration date) > > > > Looks like since this commit the travis builds are broken: > > 001+ Warning: DateTime::createFromFormat(): It is not safe to rely > on > the system's timezone settings. You are *required* to use the > date.timezone setting or the date_default_timezone_set() function. > In > case you used any of those methods and you are still getting this > warning, you most likely misspelled the timezone identifier. We > selected > the timezone 'UTC' for now, but please set date.timezone to select > your > timezone. in /home/travis/build/php/php- > src/ext/date/tests/bug53879.php > on line 2 And, BTW, can the grammatical error in that message be fixed, please? "In case" should be "If". <minor-rant> (This is a mistake I often see particularly from people whose native language is a Germanic one -- which would include Dutch! I find this usage particularly jarring, since as a native English speaker I interpret a sentence beginning "In case" in a completely different way, and then have to re-parse half-way through when I realise it should have begun "If". Roughly speaking, I take "In case x..." to mean something like "As a preventative measure against the unlikely event that x should happen..." -- as in "In case this function call throws an Exception, we wrap it in a try/catch block.".) </minor_rant> (Short version: "In case..." does not mean "If..."!) Cheers! Mike -- Mike Ford, Electronic Information Developer, Libraries and Learning Innovation, 403a Leslie Silver Building, City Campus, Leeds Metropolitan University, Woodhouse Lane, LEEDS,  LS1 3ES,  United Kingdom E: m.ford@leedsmet.ac.uk T: +44 113 812 4730 To view the terms under which this email is distributed, please go to http://disclaimer.leedsmet.ac.uk/email.htm