Re: fix for bug #26696
| From: | Andi Gutmans | Date: | Tue, 13 Jan 2004 21:08:43 +0000 |
| Subject: | Re: fix for bug #26696 | ||
| References: | 1 2 3 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-7063@lists.php.net to get a copy of this message | ||
At 04:06 PM 1/13/2004 -0500, Sterling Hughes wrote:
Are you sure this is OK? It seems strange that string offsets don't need
any unlocking. It might mean we have a problem someplace else and that
you're fixing the cause and not the source of the problem (although I
haven't had time to dig deep).
In general, consider the following code:
$a = "Foo";
switch ($a[0]) {
case 'b':
break;
case 'c':
break;
case 'F':
break;
}
Are you sure this doesn't leak now? I don't have time to look at it now,
but if you are absolutely convinced the patch makes sense I'll try and step
through it with a debugger as soon as I have some free time.
No, I was wrong. I hate the memory manager, it cleans up my leaks for
me - makes it impossible to rely on valgrind. ;) Anyway to turn that off?
If you're running in --enable-debug it should be telling you about the leaks.
I'm playing around some more now.OK thanks. Andi