Re: Re: imagecrop fix
| From: | Gmail | Date: | Sat, 28 Dec 2013 04:04:34 +0000 |
| Subject: | Re: Re: imagecrop fix | ||
| References: | 1 2 3 4 5 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-70893@lists.php.net to get a copy of this message | ||
Sent from my iPhone
> On Dec 28, 2013, at 11:10 AM, Pierre Joye <pierre.php@gmail.com> wrote:
>
>> On Dec 28, 2013 5:47 AM, "Rasmus Lerdorf" <rasmus@lerdorf.com> wrote:
>>
>>
>> And much of that code isn't in 5.3. ImageCrop() is new in 5.5, for
> example.
>
> Yes, but the commit changed other functions (news has to be updated
> accordingly). I won't be able to test or valid the patch before the 6th, so
> if anyone likes or has time to do it, go ahead.
No behavior changed, previously , these function will modify the parameter if the item in it is not
expected type, it should be fixed.
Thanks
>
> Cheers,
> Pierre