Re: CURLOPT_CLOSEPOLICY

On 13 January 2014 20:09, Hannes Magnusson <hannes.magnusson@gmail.com> wrote: > On Mon, Jan 13, 2014 at 3:08 AM, Chris Wright <daverandom@php.net> wrote: >> It would appear that this option does not do anything: >> >> >> http://curl.haxx.se/libcurl/c/curl_easy_setopt.html#CURLOPTCLOSEPOLICY >> >> ...and never has. >> >> http://curl.haxx.se/mail/lib-2006-11/0301.html >> >> Anyone got any objections to it simply being removed from the manual? >> > > > We need to list all defined constants. No matter what they do. > > Remove it from php-src, and then add a changelog entry to the docs is > imo the correct way to go. > > > -Hannes Further to the above as discussed on the docs list, does anyone have any objections to removing this from php-src? Since it doesn't actually do anything in libcurl it's a fairly safe assumption that this will not be a meaningful BC break. I've created a PR to remove it, it's against 5.4 but if people would rather it could just go into 5.6: https://github.com/php/php-src/pull/563 The alternative would be to simply document that it does nothing and leave it in, but I personally would rather clean up things like this, since the clean up is not going to break anything in any real sense. Thanks, Chris