Re: [RFC] Module API Introspection

On Fri, Jan 24, 2014 at 1:53 PM, Sara Golemon <saramg@gmail.com> wrote: > Resend 'cause my usual account keeps getting bounced. > > -Sara > >>> We talked about this with Sara this morning, but I see she already >>> worked on a patch :D >>> Wonderful. >> I was done by the end of the coffee break. :p >> >>> Can we use this step to merge this as well ? >>> >>> https://github.com/jpauli/php-src/tree/remove_old_php4_dl >>> I can update the RFC if needed. >> I was thinking about that as I was looking in there, yeah. >> >> I don't think we need an RFC for that though. It's just general code cleanup >> which doesn't impact any user experience (that we have any reason to care about). >> >>> Perhaps we could as well refactor the code as Sara's patch uses nearly >>> the same code as in dl.c? >> Yeah, fair point, I'll move the load (and failure errors) out into a helper after Liz >> Smith's keynote is done. You are so crazy coding Sara. I absolutely love when (pretty easy) things move this fast. Talk, agree, code, commit, done. Just nice. Julien