Re: [RFC] 64 bit platform improvements for string length and integer
| From: | Christopher Jones | Date: | Fri, 24 Jan 2014 16:51:26 +0000 |
| Subject: | Re: [RFC] 64 bit platform improvements for string length and integer | ||
| References: | 1 2 3 4 5 6 7 8 9 10 11 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-71520@lists.php.net to get a copy of this message | ||
On 1/24/14 1:43 AM, Anatol Belski wrote:
Hi Chris, On Thu, January 23, 2014 21:36, Christopher Jones wrote:Have as much as can be done via macros to minimize the number of lines that need to be modified in a file. Chris -- christopher.jones@oracle.com http://twitter.com/ghrd Free PHP & Oracle book: http://www.oracle.com/technetwork/topics/php/underground-php-oracle-manual-098250.htmlOn 01/23/2014 12:36 PM, Christopher Jones wrote:The macros are easy done of course, but the long/int keywords would conflict with the built-in types, wouldn't they? Well, if zpp var datatypes were still replaced, it should work. Is that what you mean? Regards AnatolFor reference, here is Anatol's mapping that allows extensions using the new types etc to compile with older PHP releases: https://github.com/php/php-src/blob/str_size_and_int64/compat/compat.h I would have leaned towards not requiring macro name changes, but I wouldn't vote against the RFC because of them.Anatol: what about creating the inverse of the compat.h #defines? Old code can include those definitions and wouldn't need as many changes?