Re: [RFC] [VOTE] __debugInfo()
| From: | Sara Golemon | Date: | Wed, 05 Feb 2014 20:01:49 +0000 |
| Subject: | Re: [RFC] [VOTE] __debugInfo() | ||
| References: | 1 2 3 4 5 6 7 8 9 10 11 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-72290@lists.php.net to get a copy of this message | ||
On Wed, Feb 5, 2014 at 11:30 AM, Rowan Collins <rowan.collins@gmail.com> wrote:
> Sara Golemon wrote (on 05/02/2014):
>> (such as current uses in dom,
>> sxe, mysqli, intl, and spl)
>
> If "sxe" in there means SimpleXML, I wish it would do a better job of it!
>
Yes, sxe is short for SimpleXML. :)
> In fact, now that I know this hook exists, and doesn't affect the action of
> array casts, I'm tempted to attempt a patch that would improve it, based on
> the simplexml_tree function I've written at
> https://github.com/IMSoP/simplexml_debug
>
Wanna lol? Here's sxe's current implementation of get_debug_info (in
ext/simplexml/simplexml.c)
static HashTable * sxe_get_debug_info(zval *object, int *is_temp TSRMLS_DC) {
*is_temp = 1;
return sxe_get_prop_hash(object, 1 TSRMLS_CC);
}
If you can even call that an implementation. :p
If you're up to improving it, that's the spot to do it.
-Sara