Re: uniqid() is not unique under windows
| From: | Yasuo Ohgaki | Date: | Sun, 09 Feb 2014 23:33:29 +0000 |
| Subject: | Re: uniqid() is not unique under windows | ||
| References: | 1 2 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-72421@lists.php.net to get a copy of this message | ||
Hi all,
On Sun, Feb 9, 2014 at 7:20 AM, Pierre Joye <pierre.php@gmail.com> wrote:
> On Sat, Feb 8, 2014 at 10:14 PM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:
> > Hi Pierre,
> >
> > Why is uniqid() is not guarantee uniqueness under windows?
> >
> > https://bugs.php.net/bug.php?id=65626
> >
> > It seems PHP_WIN32 and __CYGWIN__ check is obsolete.
> > Could it be removed?
>
> Not sure, we have to test to see if it is necessary.
>
> But for cygwin, we do not support it so I won't do any testing with it.
https://github.com/yohgaki/php-src/commit/6c36a82ee84cfda0cb14c95b0c035849f73d8354
Here is simple patch to test for windows. Could anyone try to see if it
works?
According to PHP_FUNCTION(microtime), it should work.
Regards,
--
Yasuo Ohgaki
yohgaki@ohgaki.net