Re: Usin ClangStatic Analyzer for zend_parse_parameters
| From: | Pierre Joye | Date: | Tue, 18 Feb 2014 17:59:08 +0000 |
| Subject: | Re: Usin ClangStatic Analyzer for zend_parse_parameters | ||
| References: | 1 2 3 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-72690@lists.php.net to get a copy of this message | ||
On Feb 18, 2014 11:01 PM, "Terry Ellison" <ellison.terry@gmail.com> wrote:
>
> Julien,
>>
>> <snip> Running this over one of my PHP builds I got those error reports:
>>
>> http://schlueters.de/zppcheck/ maybe somebody wants to go
>> through them
>> and fix at least the trivial ones.
>
> By the way, your report seems to be listing entries twice -- at least as
the four PHPdbg SAPI ones. In this case these are all a case of the "s"
parameter taking a char**, int* but phpdbg.c is passing in a char**, uint*.
I'll issue a patch for Joe or Bob to review and push into PHP-5.6.
>
> Note that http://www.php.net/manual/en/internals2.funcs.php
> states that
the "s" parameter takes the addresses of char*, uint that is char** uint*
which is wrong. Though why the length field should be signed seems odd to
me as a negative length makes no sense at all.
Right, that is something we have fixes in the int64 and sizet branch.
Cheers,
Pierre