Re: [VOTE] CI tests RFC

hi, On Sat, Apr 26, 2014 at 11:38 AM, Derick Rethans <derick@php.net> wrote: > On Fri, 25 Apr 2014, Stas Malyshev wrote: > >> I'd like to propose the CI tests RFC for the vote. Please vote at: >> https://wiki.php.net/rfc/travis_ci >> >> The vote is planned to close on May 5. If you have any questions, >> please contact me. > > I have a comment (not specifically to you). We can't seriously be > suggesting that RMs can just revert commits. This is a really rude thing > to do in an open source project. We're doing this for fun, and people > immediately reverting your commits takes (more) fun out of it. - review - ask for fix - revert I do not see what is rude here. However not fixing a patch within a couple of days (as in commit and run), after other has reported issues, is actually rude. This procedure should have happened long time ago already, at least for stable branches. I would go even one step further, only allow RMs to cherry pick patches and let devs commit to dev branches, be master or next patches release for stable dev branches. Doing so will allow much faster security releases for example and avoid last minutes patches breaking a release. Cheers, -- Pierre @pierrejoye | http://www.libgd.org