Re: CI tests RFC - vote results

On Wed, May 7, 2014 at 9:26 PM, Stas Malyshev <smalyshev@sugarcrm.com>wrote: > Hi! > > > So, to clarify, does this mean that, in future, we’ll be changing tests > > to accept bugs if trunk contains the bug? > > This means that changing test is one of the acceptable solutions to fix > CI failure. Of course, if it is a bug, then it makes no sense to change > the test, in that case the change has to be reverted. > > -- > Stanislav Malyshev, Software Architect > SugarCRM: http://www.sugarcrm.com/ > (408)454-6900 ext. 227 > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > > This is why I didn't liked that option, as that option only makes sense, when doing it is plain wrong. If somebody fixed a bug, which broke a test, but the change is intentional or unaviodable then fixing the test is the right thing to do, and doesn't really requires any rfc to support. If somebody changed something, which broke some test unintentionally or without proper justification then updating the test to accomodate the new behavior without ringing the alarm bell is a bad thing to do imo. But of course they are only options, so I guess people/RMs won't really use it to shot themselfs to the leg. -- Ferenc Kovács @Tyr43l - http://tyrael.hu