Re: Re: Broken tests

2014.05.23. 17:37, "Adam Harvey" <aharvey@php.net> ezt írta: > > On 23 May 2014 02:11, Stas Malyshev <smalyshev@sugarcrm.com> wrote: > > Your commit fdb2709dd27c5987c2d2c8aaf0cdbebf9f17f643 broke test > > dateformat_format.phpt. Please fix it ASAP. > > Fixed. My apologies. If these e-mails are somewhat automated, it would > be useful to know which branch(es) were broken. > > Also: is it just me, or do we have a bunch of failing tests on > ext/intl on PHP-5.4? The noise floor there seems odd, given that the > ext/intl test suite passes for me on 5.5 and later on the same VM. > > Adam > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > My guess is that Stas sent his mail based on the travis report. We don't allow travis to test the 5.4 branch (not sure why), so I wouldn't be surprised if those failing 5.4 tests are fixed in 5.5 and up where they are more visible. Stas, Nikita(afair it was you who restricted the travis branches to 5.5 and up) are there any strong arguments for keeping the 5.4 branch disabled on travis?