Re: Can someone with Zend karma please merge PR #674?
| From: | Levi Morrison | Date: | Mon, 09 Jun 2014 01:41:07 +0000 |
| Subject: | Re: Can someone with Zend karma please merge PR #674? | ||
| References: | 1 2 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-74790@lists.php.net to get a copy of this message | ||
On Sun, Jun 8, 2014 at 5:57 PM, Stas Malyshev <smalyshev@sugarcrm.com> wrote:
> Hi!
>
>> https://github.com/php/php-src/pull/674
>>
>> It fixes bug 66622: https://bugs.php.net/bug.php?id=66622
>> I've prodded people on #php.pecl and nobody has had any complaints
>
> Didn't we just has a discussion about it an hour ago?
>
>> about it, so I don't anticipate any issues; if there is an issue do
>> let me know.
>
> I still don't think we should move the tests around.
I've rebased the PR to not change the phpt locations even though I
think they are better in a subdirectory.
A local
make test shows nothing has been broken; Travis CI will
hopefully confirm the same in a bit.