Re: [PR][php-src][#693][master][opened] - pcntl_signal_dispatch: Speed up by preventing system calls when unnecessary
| From: | Ferenc Kovacs | Date: | Thu, 12 Jun 2014 12:14:12 +0000 |
| Subject: | Re: [PR][php-src][#693][master][opened] - pcntl_signal_dispatch: Speed up by preventing system calls when unnecessary | ||
| References: | 1 2 3 4 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-74870@lists.php.net to get a copy of this message | ||
On Thu, Jun 12, 2014 at 1:51 PM, Derick Rethans <derick@php.net> wrote:
> On Wed, 11 Jun 2014, Andrea Faulds wrote:
>
> >
> > On 11 Jun 2014, at 17:17, Derick Rethans <derick@php.net> wrote:
> >
> > > Why is this not going to git-pulls@ ? Please don't make new PRs drown
> in
> > > the noise that internals (can be).
> >
> > They’re hardly *drowning* internals. Furthermore, said patches will
> > eventually be announced on internals anyway if they don’t get merged.
> >
> > I say keep them here.
>
> I say you don't make that decision on your own. We have a list for it,
> put it on there.
>
> And right now, the subject lines are pretty useless too. On
> smaller devices, I see "[PHP-DEV] [PR][php-src][#693][master][opened] -
> pcntl_signa"
>
> I care neither about the repository, number, the branch, or whether it
> is opened at
> a glance, but merely the PR. This should go in the body of the
> mail. "[PHP-DEV] [PR]" is also not needed beacuse it needs to go onto
> it's already existing list.
>
[PHP-DEV] is not added by the script, but the mailing list
[PR] was added so people who aren't interested in PRs can easily filter it
same for the the repo name, I think you are right that the PR number and
status doesn't need to be in the subject, I will fix that.
--
Ferenc Kovács
@Tyr43l - http://tyrael.hu